Fix user attribute fallback #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: spec/omniauth/strategies/ldap_spec.rb
The first email attribute we check for is 'mail', then 'email'. By returning an 'email' attribute in the test response we trigger the fallback to the second attribute. This makes a test fail.
Net::LDAP::Entry returns empty array if key not exists, so we should check for key with respond_to?
|
I believe this should be fixed now that PR #10 was applied. |
|
It is. Thanks @jhollingsworth ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of the omniauth user attributes that omniauth-ldap fetches from the LDAP server we have a list of fallback options in case an attribute is missing, for example:
This means that if the LDAP object for the user does not have a
mailattribute, omniauth-ldap will try theemailattribute, and then theuserPrincipalNameattribute.This attribute fallback was broken. In this PR we cherry-pick the upstream commits that fix this functionality, and we modified the tests to catch future regressions.